Decathlon / vitamin-ios

Decathlon Design System UI components for iOS & iPadOS applications
https://www.decathlon.design
Apache License 2.0
46 stars 14 forks source link

feat: update icons #127

Closed lauthieb closed 1 year ago

lauthieb commented 1 year ago

Automated Pull Request to update icons.

daniel-dumortier commented 1 year ago

If Vitamix is now a generated class, we should maybe add it to sonar.cpd.exclusions to avoid quality date failure on Sonar du to code duplication

lauthieb commented 1 year ago

@daniel-dumortier you're right! Feel free to anticipate this in another branch that we will merge before this PR

lauthieb commented 1 year ago
CleanShot 2023-03-13 at 22 59 53@2x

@florentlotthepro Can you rename IconModel+Sections.swift to IconsModel+Sections.swift in order to align with the existing file called IconsModel.swift? Thanks.

@mackoj for your info

florentlotthepro commented 1 year ago

@lauthieb Fixed 🙂

lauthieb commented 1 year ago

Thanks @florentlotthepro!

@daniel-dumortier @mackoj can we please have your review in order to merge this PR? 🙏

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication