New TextStyle value for buttons implementation (cf. https://decathlon.atlassian.net/browse/CNT-1085)

DamienBallenghien commented 1 year ago

Changes description

https://decathlon.atlassian.net/browse/CNT-1085

Checklist

[x] Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
[x] Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
[x] Check your code additions will fail neither code linting checks.
[x] I have reviewed the submitted code.
[x] I have tested on an iPhone device/simulator.
[x] I have tested on an iPad device/simulator.
[x] If it includes design changes, please ask for a review design-system-core-team-design GitHub team.

Does this introduce a breaking change?

Yes It could impact some apps on Buttons style.

Screenshots

un-aligned	aligned

CLAassistant commented 1 year ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: mackoj
:x: DamienBallenghien
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

mackoj commented 1 year ago

Thanks for you PR I'm gonna look into it.

mackoj commented 1 year ago

After testing this patch, it doesn't seem to affect the icon placement of any icon provided by the library. I might be missing some context to accurately reproduce this bug and confirm that the patch provided fixes it. Sorry for the delay; it took me some time to properly test the library.