search

Decathlon / vitamin-ios

Decathlon Design System UI components for iOS & iPadOS applications
https://www.decathlon.design
Apache License 2.0
46 stars 14 forks source link

Add snapshots for all buttons configurations #153

Closed mackoj closed 1 year ago

mackoj commented 1 year ago

Add test for all buttons icons

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

florentlotthepro commented 1 year ago

Isn't it possible to store images somewhere else? All images are approximately 4 MB. It will be 4 MB (unused) to download every time we need to check out the package. It's not huge but it's the beginning and not really green IT.

mackoj commented 1 year ago

I don't think I will merge this. I did this in order have a proper way to compare how the patch #150 does affect the code but I do prefer to keep only one case with one image that we already have.