Decathlon / vitamin-ios

Decathlon Design System UI components for iOS & iPadOS applications
https://www.decathlon.design
Apache License 2.0
46 stars 14 forks source link

refactor: change conversion button content color #30

Closed GaspardMathon closed 2 years ago

GaspardMathon commented 2 years ago

Describe the solution you'd like

Additional context

daniel-dumortier commented 2 years ago

@GaspardMathon I think this issue is not relevant, because that is already the case in the latest release (which is the first on this repo) :

extension VitaminButton.Style {
    var foregroundColor: UIColor {
        switch self {
        case .primary:
            return VitaminColor.Core.Content.primaryReversed
        case .primaryReversed:
            return VitaminColor.Core.Content.primary
        case .secondary, .tertiary:
            return VitaminColor.Core.Content.action
        case .conversion:
            return VitaminColor.Core.Content.accent
        case .ghost:
            return VitaminColor.Core.Content.active
        case .ghostReversed:
            return VitaminColor.Core.Content.actionReversed
        }
    }
}
lauthieb commented 2 years ago

Nice! Thanks @daniel-dumortier