Decathlon / vitamin-ios

Decathlon Design System UI components for iOS & iPadOS applications
https://www.decathlon.design
Apache License 2.0
46 stars 14 forks source link

refactor: replace toggle color for dark mode #29 #35

Closed florentlotthepro closed 2 years ago

florentlotthepro commented 2 years ago

Changes description

Findings:

On vitamin, toggle button switch from white to dark depending on the theme selected Toggle button on iOS dark mode is still white (there is no color switch).

Proposal

In order to respect the platform as much as possible, I propose to replace the semantic coloring by a color base

Context

Checklist

Does this introduce a breaking change?

Screenshots

dark_mode_switch

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

florentlotthepro commented 2 years ago

Yes 😅