fix: SwiftUI TextStyle modifier line height - Githubissues

Decathlon / vitamin-ios

Decathlon Design System UI components for iOS & iPadOS applications

https://www.decathlon.design

Apache License 2.0

46 stars 14 forks source link

fix: SwiftUI TextStyle modifier line height #87

Closed florentlotthepro closed 1 year ago

florentlotthepro commented 1 year ago

Changes description

I fixed the line height calculation to get the correct value.

Context

The line height when using the .vitaminTextStyle modifier was not correct.

Checklist

[x] Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
[x] Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
[x] Check your code additions will fail neither code linting checks.
[x] I have reviewed the submitted code.
[x] I have tested on an iPhone device/simulator.
[x] I have tested on an iPad device/simulator.

Does this introduce a breaking change?

No

Screenshots

Before	After

With dynamic type enabled

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication