feat: add new icons - Githubissues

florentlotthepro commented 1 year ago

Changes description

Added new icons.

[x] add-circle-fill ➡️ added ✅
[x] add-circle-line ➡️ added ✅
[x] barcode-fill ➡️ added ✅
[x] barcode-line ➡️ added ✅
[x] customer-service-fill ➡️ added ✅
[x] customer-service-line ➡️ added ✅
[x] file-copy-fill ➡️ added ✅
[x] file-copy-line ➡️ added ✅
[x] kakao-talk-line ➡️ added ✅
[x] kakao-talk-fill ➡️ added ✅
[x] github-fill ➡️ added ✅
[x] github-line ➡️ added ✅
[x] line-line ➡️ added ✅
[x] line-fill ➡️ added ✅
[x] naver-line ➡️ added ✅
[x] naver-fill ➡️ added ✅
[x] pie-chart-fill ➡️ no changes ⏸
[x] pie-chart-line ➡️ no changes ⏸
[x] qr-scan-fill ➡️ added ✅
[x] qr-scan-line ➡️ added ✅
[x] rocket-line ➡️ added ✅
[x] rocket-fill ➡️ added ✅
[x] search-fill (design update) ➡️ Updated 🔄
[x] share-android-fill ➡️ added ✅
[x] share-android-line ➡️ added ✅
[x] share-ios-fill ➡️ added ✅
[x] share-ios-line ➡️ added ✅

Context

New icons were added in the Figma file.

Checklist

[x] Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
[x] Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
[x] Check your code additions will fail neither code linting checks.
[x] I have reviewed the submitted code.
[x] I have tested on an iPhone device/simulator.
[x] I have tested on an iPad device/simulator.
[x] If it includes design changes, please ask for a review with a core team designer.

Does this introduce a breaking change?

No

Screenshots

iPhone

Capture d’écran 2022-10-28 à 21 35 53

Other information

Close #91

daniel-dumortier commented 1 year ago

@florentlotthepro I did not have time to make a full review, but I had a feedback on icons from a developer about Vitamix icons.

It seems that when you try to display a Vitamix icon in a bigger size, it is pixelized. And that we could avoid that by checking "Preserve Vector Data" on each icon in assets catalog (in the right panel, in Image Set tab)