Decathlon / vitamin-web

Decathlon Design System UI components for web applications
https://decathlon.github.io/vitamin-web
Apache License 2.0
279 stars 77 forks source link

feat: add a prop to hide search button in `Search` component #1369

Closed lauthieb closed 1 year ago

lauthieb commented 1 year ago

Changes description

Closes #1358

CleanShot 2023-02-09 at 20 18 28@2x

For your information, I will ask designers to rename the Figma variant "Show search" => "Show search button"

CleanShot 2023-02-09 at 21 14 05@2x CleanShot 2023-02-09 at 21 12 58@2x CleanShot 2023-02-09 at 21 13 32@2x

Checklist

Does this introduce a breaking change?

Other information

thibault-mahe commented 1 year ago

To make sure I understand, the original ticket said:

A search similar to the native one on Android and IOS with a 🔍 search icon on the left to indicate that it's a search bar, but not as a button to validate.

but here the decision is to remove the icon, is this right?

lauthieb commented 1 year ago

@thibault-mahe, yes :)