Closed Tlahey closed 1 year ago
Hi @Tlahey, Thanks for your PR, I just proposed you a meeting when you will be back to work next Monday to discuss about this. See you soon. Laurent
Thanks @Tlahey, that's ok for me!
I also added it this fix for React & Vue implementation of the VtmnRating
component.
Changes description
After checking the Decathlon website, I saw many products that the stars are stuck at 4.5.
But some of them are a rating > 4.7.
Context
The rule on the current component is :
But here with a value > 4.5 we don't round.
The question here is, what we defined when a number is > 4.5. I've discuss with @lauthieb, we need to speak about it, maybe take the example of Google that round the value with the nearest one.
And write this rule on the Design System website so that there are no more questions about it.
Checklist
design-system-core-team-design
GitHub team.Does this introduce a breaking change?
No breaking changes
Other information
This PR aims to enhancer the storybook
readonly
are true / falseImprove tests
VtmnIcon
who has to be displayed. Add more tests on this function.