bug(@vtmn/react) `VtmnDropdown` component always display label although it is not configured

[jdeca-decat]

Describe the bug In the React Showcase of the VtmnDropdown component, it say that if the label is not set, it will not disayed but it's still here

Steps to reproduce

• install React
• install Vtmn package for React

Expected behavior Normally, if the label is not set, it does not appear

Version affected @react: 18.2.0 @vtmn/react: 0.67.0

[jdeca-decat]

While waiting for the bug to be fixed, I added a style rule: .vtmn-dropdown > label { display: none; }

[lauthieb]

Thanks @jdeca-decat for this issue. As the @vtmn/react is a community library, I hope someone will take this issue to help you. If you want, feel free to contribute also! We are there to help you if needed regarding launching & contributing on the vitamin-web stack.

[0x2A-git]

Hi @jdeca-decat,

Following our last discussion from #1401 I'm glad you've been able to solve your issue.

I've just opened a P.R in order to solve this issue so that we won't have to use a CSS workaround anymore :)

[jdeca-decat]

Thanks @0x2A-git I'll take a look ! But.. I stopped using the VtmnDropdown, because I had another problem: there is no documentation and no option to configure the dropdown in single selection mode. I want to disable multiselect default option but there is no way apparently :(

[0x2A-git]

Thanks @0x2A-git I'll take a look ! But.. I stopped using the VtmnDropdown, because I had another problem: there is no documentation and no option to configure the dropdown in single selection mode. I want to disable multiselect default option but there is no way apparently :(

Did you take a look at the Select component ? It might suit your use case :) ( https://www.decathlon.design/726f8c765/p/46ee45-select/b/97a60e/t/951797 )

[jdeca-decat]

Thanks @0x2A-git I'll take a look ! But.. I stopped using the VtmnDropdown, because I had another problem: there is no documentation and no option to configure the dropdown in single selection mode. I want to disable multiselect default option but there is no way apparently :(

Did you take a look at the Select component ? It might suit your use case :) ( https://www.decathlon.design/726f8c765/p/46ee45-select/b/97a60e/t/951797 )

In fact, I have to respect a mockup given by a ui designer. He wants to use the dropdown rather than the select for aesthetic reasons but I'll tell him to make a deal ! Thanks to you ;)

[lauthieb]

Great idea :) Accessibility + web standards + usage > aesthetic

[thibault-mahe]

Closed by https://github.com/Decathlon/vitamin-web/pull/1405, thanks @0x2A-git !