Decathlon / vitamin-web

Decathlon Design System UI components for web applications
https://decathlon.github.io/vitamin-web
Apache License 2.0
279 stars 77 forks source link

feat(`@vtmn/svelte`): add focus event support for Svelte version of `VtmnTextInput` #1433

Closed BasileRaiwet closed 1 year ago

BasileRaiwet commented 1 year ago

Changes description

Adding support of focus event on the VtmnTextInput for svelte. This change has been archived by adding on:focus directive to the input and textarea elements.

Context

We are currently using this component in Belgium (NFS) and we need to handle the focus event. Actually we need to do it by manipulating the DOM and adding event listener manually, which is not great In terms of readability and maintainability.

Checklist

Does this introduce a breaking change?

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

BasileRaiwet commented 1 year ago

@Tlahey @thibault-mahe When can we expect this PR to be merged / deployed ? Just to get an idea, because it could really help us in a current development

lauthieb commented 1 year ago

Hi @BasileRaiwet, thanks for this PR! I just came back from vacation. For me that's ok, I approved. I just wait for the CI and when all it's ok, I merge it :)