search

Decathlon / vitamin-web

Decathlon Design System UI components for web applications
https://decathlon.github.io/vitamin-web
Apache License 2.0
279 stars 77 forks source link

feat: enhancement `VtmnCard` variant for SSR #1444

Closed Tlahey closed 1 year ago

Tlahey commented 1 year ago

Hello,

We need to think about improving the card for SSR mode.

Currently, when we load a card, we apply a variant to it. In our case, a variant can be applied depending on the mobile / tablet / desktop device.

It is possible to modify this variation but it is not done on the SSR side!

Today, we have to create the component twice, with the same data and apply a query on top of it in order to switch between the devices.

Therefore, it would be interesting to find a solution to apply the variant CSS classes according to the user's device.

The goal here, would be to think about how to say to the component for example:

We need to think about a solution on this thread ping @EGilleron , @manglard

lauthieb commented 1 year ago

Agree. I let you decide at the community level and we will point this to our next implementation where you contribute internally.

stale[bot] commented 1 year ago

This has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reopen whenever you want. Thank you for your contributions.