search

Decathlon / vitamin-web

Decathlon Design System UI components for web applications
https://decathlon.github.io/vitamin-web
Apache License 2.0
279 stars 77 forks source link

feat(@vtmn/css): enhancement `VtmnSelect` make the props label optional #1448

Open Mig-l opened 1 year ago

Mig-l commented 1 year ago

Describe the bug

image

We need to use the VtmnSelect without the label. The label props is mandatory

image

If we pass the label props with an empty string, we still have an HTML label tag that is generated but empty.

image

Steps to reproduce

https://decathlon.github.io/vitamin-web/@vtmn/showcase-svelte/?path=/story/components-forms-vtmnselect--overview

Expected behavior

We have in production a select without label for the choice of the language that we must switch to Vitamin

image

We will want to use the VtmnSelect without the label

stale[bot] commented 1 year ago

This has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reopen whenever you want. Thank you for your contributions.