search

DecentSoftware-eu / DecentHolograms

A lightweight but powerful hologram plugin with many features and configuration options.
https://www.spigotmc.org/resources/96927/
GNU General Public License v3.0
211 stars 101 forks source link

Allow URL argument in setSkullTexture() #213

Open EvModder opened 6 months ago

EvModder commented 6 months ago

For the setSkullTexture() method in SkullUtils.java:

public static void setSkullTexture(@NonNull ItemStack itemStack, @NonNull String texture);

... Allow the texture argument to be either a Base64 or URL, with some basic validation

EvModder commented 3 months ago

Unfortunately I don't have the development branch in which I originally drafted this PR, and although I could recreate it I also just don't have as many free cycles in my day for open source community contributions like this at the moment :(

It looks like it's pretty close to complete how the project owners want it to be, so maybe another author can step in and complete this.

For context, I only sent this PR because someone from the DecentHolograms dev team was asking about it in a mutual Discord, I am not actually a regular contributor (or even a user) of this project, so I just wanted to give an example of how they could support it.