search

DecentSoftware-eu / DecentHolograms

A lightweight but powerful hologram plugin with many features and configuration options.
https://www.spigotmc.org/resources/96927/
GNU General Public License v3.0
211 stars 100 forks source link

Ability to use animations inside placeholders #239

Closed z2vvqx closed 2 months ago

z2vvqx commented 2 months ago

Just making sure

Problem

I am unable to achieve 'the ability of parsing the animations that are sent with my placeholder, I want to display an animation with the placeholder I'm sending' I think it would be useful for 'displaying animations inside placeholders, such as if the placeholder doesn't exist for a certain name. I can display an animated "Unavailable..." with the dots animating and etc.'

Feature

I would like to see 'ability to parse animations that are sent within placeholders'

Alternatives

It would also be possible by doing '...'

Andre601 commented 2 months ago

That is pretty much impossible to do here. DH does nothing more than sending the line to PlaceholderAPI to parse and display whatever it returns.

Anything related to placeholders has to be done by the Placeholder expansion and not DH.

z2vvqx commented 2 months ago

I'm using internal placeholders, like hooking into papi with my own plugin to display the values. Is there anything I can do to fix or implement this?

d0by1 commented 2 months ago

So you want to use animations in values returned by placeholders right? Like a placeholder returning <#ANIM:...>...</#ANIM>?

Animations like that will currently not work. The problem is this line: https://github.com/DecentSoftware-eu/DecentHolograms/blob/a1374985faa80165aecccb4ad230231cfa8950e6/src/main/java/eu/decentsoftware/holograms/api/holograms/HologramLine.java#L322

Question is, if we want to allow this. It doesn't seem to bring much value for the performace impact it would have. We would have to check for the animations on every content update and there is a good reason we don't do that. Maybe a config option could be added, similar to the one allowing placeholders inside animations.

z2vvqx commented 2 months ago

That's exactly what I'm trying to do, and honestly I didn't know it'll be a performance impact. Could be useful to have a config option like you said but now I don't even want to use that if there's an impact, thanks