DeebotUniverse / Deebot-4-Home-Assistant

Home Assistant integration for deebot vacuums
https://deebot.readthedocs.io/integrations/home-assistant/
GNU General Public License v3.0
180 stars 41 forks source link

Room attributes are missing if the map is disabled #404

Closed cpwc closed 1 year ago

cpwc commented 1 year ago

Checks

The problem

Before upgrading I'm still able to see room details within the vacuum attributes. After upgrading the attributes are no longer available and it only shows lastError as part of the attributes.

Diagnostics information

deebot-ba5a346b4d1784b578223bef8dd1b11e-None-7e055a4ef67a0a4f5781f06315b557cb.json.txt

Anything in the logs that might be useful for us?

No response

Additional information

DEEBOT X1 OMNI

eXitus01 commented 1 year ago

i cannot see also the floor after the update.

redford-jones commented 1 year ago

Yes, same issue here, but I think I may have resolved it.

Initially, after updating to the new new release, the attributes shown on my DEEBOT OZMO 920 Series were as follows:

fan_speed_list:
  - quiet
  - normal
  - max
  - max_plus
battery_level: 100
battery_icon: mdi:battery-charging-100
fan_speed: max_plus
last_error: 'NoError: Robot is operational (0)'
friendly_name: Diva
supported_features: 13180

I then went into the device, noticed that the new Map Controls entity was disabled. I enabled it via the entity properties dialog, disabled the old Live Map sensor and reloaded the integration. Attributes are now shown as:

fan_speed_list:
  - quiet
  - normal
  - max
  - max_plus
supported_features: 13180
battery_icon: mdi:battery-charging-100
friendly_name: Diva
rooms:
  default:
    - 1
    - 4
    - 0
    - 9
    - 11
  laundry: 6
  kitchen: 10
  living_room: 5
  sunroom: 7
  dining_room: 2
last_error: 'NoError: Robot is operational (0)'
battery_level: 100
fan_speed: max_plus
edenhaus commented 1 year ago

@redford-jones Thanks for the hint. I will check the code to see if the map changes in 2.0.0 introduced this bug.

@cpwc Do you have the map disabled?

redford-jones commented 1 year ago

@redford-jones Thanks for the hint. I will check the code to see if the map changes in 2.0.0 introduced this bug.

@cpwc Do you have the map disabled?

My debug logs from prior to enabling the Map entity attached if that helps you at all?

Deebot_DEBUG_log_080823.log

cpwc commented 1 year ago

@edenhaus @redford-jones is exactly spot on. The map entity was not enabled and once I had it enabled. I am seeing the rooms attributes.

Last error
NoError: Robot is operational (0)
Rooms
study: 0
kitchen: 1
living_room: 2
corridor: 6
default: 7
edenhaus commented 1 year ago

@redford-jones If you want, you can try to fix it in the library. I'm here to help.

Otherwise, I will fix it by the end of the week :)

KiraPC commented 1 year ago

@edenhaus any updates on this?

edenhaus commented 1 year ago

@KiraPC Thanks for reminding me about the issue. I had a family emergency in August, and afterwards, I didn't remember me to fix it.

KiraPC commented 1 year ago

@edenhaus thanks to you for this amazing integration. Personal issue before everything for sure 😁 hope now is everything good