No dependencies besides docker required, including java, maven, etc. (Nice for CI)
Use docker layer cache to avoid downloading dependencies every build (Nice for rebuilding locally multiple times)
Redownload all dependencies based on when pom.xml is changed (This is a bit of a compromise, but I hope not a big deal since pom.xml doesn't change very often)
Also substitute deprecated "MAINTAINER" step in favor of "LABEL".
Flattened the docker directory into the repo root since it isn't being used the same way anymore.
Also simplified the Makefile since it doesn't have to do as much.
The docker build itself seems to complete without issue, but that's obviously not the same as testing it live. So I'm not sure if the resulting image works the same. If I determine that I will post with my results.
I'm very open to feedback and would be happy to discuss my motivations for these changes and make adjustments to better fit the desired direction of the project. Thank you for zkui!
Some differences:
Also substitute deprecated "MAINTAINER" step in favor of "LABEL".
Flattened the docker directory into the repo root since it isn't being used the same way anymore.
Also simplified the Makefile since it doesn't have to do as much.
The docker build itself seems to complete without issue, but that's obviously not the same as testing it live. So I'm not sure if the resulting image works the same. If I determine that I will post with my results.
I'm very open to feedback and would be happy to discuss my motivations for these changes and make adjustments to better fit the desired direction of the project. Thank you for zkui!