search

DeepLcom / deepl-rb

Official Ruby library for the DeepL language translation API.
https://www.deepl.com
MIT License
8 stars 2 forks source link

Document translation example in README wrong #2

Closed JanEbbing closed 1 month ago

JanEbbing commented 2 months ago

The document translation example in the README is currently wrong, the order of arguments is different and a filename needs to be supplied

Wrong:

DeepL.document.translate_document('/path/to/spanish_document.pdf', 'ES', 'EN', '/path/to/translated_document.pdf')

Correct:

DeepL.document.translate_document('/path/to/spanish_document.pdf', '/path/to/translated_document.pdf', 'ES', 'EN', 'spanish_document.pdf')

I am keeping this issue to track this for now, I already have a fix that fixes the README and makes the filename argument optional.

JanEbbing commented 1 month ago

Fixed in 3.0.1