search

Deepwalker / trafaret

Ultimate transformation library that supports validation, contexts and aiohttp.
http://trafaret.readthedocs.org/en/latest/
BSD 2-Clause "Simplified" License
177 stars 31 forks source link

DeprecationWarning on import of abstract classes from collections #51

Closed fly closed 4 years ago

fly commented 5 years ago

In python 3.7 I'm getting the following deprecation warning:

DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working

collections.abc is available starting from python 3.3.

Are there any plans on fixing it? (I guess you want to retain python2 support yet)

Also I don't mind to create PR to fix this. If you agree, do you have any preferred way this to be done?

Deepwalker commented 5 years ago

fixed it in version2 branch. Hope we will make release before 3.8

asvetlov commented 5 years ago

Please do. Python relaxed the deprecation period to 3.9 but please take the warning seriously. Now it requires an extra line in pytest configuration section for almost every project on my job :)

Would you consider trafaret==1.2.1 bugfix release with fixed import?

tirkarthi commented 4 years ago

I guess this was fixed with https://github.com/Deepwalker/trafaret/pull/81 . Also the removal has been postponed to python 3.10.

Deepwalker commented 4 years ago

Tnx, forgot to close this after release.