search

DefangLabs / defang

Defang CLI and sample projects. Defang is a radically simpler way for developers to develop, deploy, and debug cloud applications.
https://defang.io
MIT License
29 stars 6 forks source link

Defang generate with Redis should automatically add x-defang #548

Open raphaeltm opened 2 months ago

raphaeltm commented 2 months ago

I generated a project with defang generate which ended up looking like this:

services:
  service1:
    restart: always
    build:
      context: .
      dockerfile: Dockerfile
    environment:
      - REDIS_HOST=redis
      - REDIS_PORT=6379

  redis:
    image: redis:alpine
    ports:
      - 6379:6379

Good starting point, but we should make sure that generated code includes x-defang-redis: true if it includes Redis at all.

raphaeltm commented 2 months ago

Also, even with x-defang-redis: true the code wouldn't work because of https://github.com/DefangLabs/defang/issues/547