search

Deleh / gis

Status summary of multiple Git repositories
7 stars 4 forks source link

[?] Update install.bash with bsd column install #9

Closed muritane closed 1 week ago

muritane commented 3 weeks ago

Does it make sense to install column here?

Deleh commented 1 week ago

I have mixed feelings about adding apt commands to the install script as this would only work for Debian-based distros. But adding a check if the column command is available would be great, something like this:

if ! command -v column &> /dev/null; then
    echo "Command 'column' not available on the system, please make sure the dependencies are fulfilled."
    exit 1
fi

What do you think?

muritane commented 1 week ago

Sure! Actually, column should be included in the util-linux standard package, i.e. pre-installed. Maybe there were many old docker containers in my case to have column missing.

Deleh commented 1 week ago

The column check was added to the install scripts in https://github.com/Deleh/gis/commit/6690c470e35053aab13911c95b100b0c81de8402.