search

Deltares / hydromt_delft3dfm

Delft3D FM plugin for HydroMT
https://deltares.github.io/hydromt_delft3dfm/
GNU General Public License v3.0
9 stars 2 forks source link

geoms are written twice during model building #174

Open shartgring opened 1 month ago

shartgring commented 1 month ago

Version checks

Reproducible Example

Image

Current behaviour

The logs show that the geoms are written twice during a single model build

Desired behaviour

Limit to writing the geoms once, for the final model

Additional context

No response

veenstrajelmer commented 1 month ago

I also see that it is done on two places in the code.

In the beginning of DFlowFMModel.write_geoms: https://github.com/Deltares/hydromt_delft3dfm/blob/5195d497bf1b0c1fc00ba5a48d565774f8856456/hydromt_delft3dfm/dflowfm.py#L3171

And also at the end: https://github.com/Deltares/hydromt_delft3dfm/blob/5195d497bf1b0c1fc00ba5a48d565774f8856456/hydromt_delft3dfm/dflowfm.py#L3237

I guess one of these should be ommitted? Would that resolve it?