Deltares / hydromt_delft3dfm

Delft3D FM plugin for HydroMT
https://deltares.github.io/hydromt_delft3dfm/
GNU General Public License v3.0
9 stars 2 forks source link

Fix `No crossections are set up` in `setup_rivers` for local model #175

Closed veenstrajelmer closed 1 month ago

veenstrajelmer commented 1 month ago

There are the following issues in setup_rivers logging for test_model_build[local] and test_model_build_local_code, maybe also for other tests:

Crosssection with id: [1]are dropped: unable to find closest branch. 
No crossections are set up.
Snapping to branches using intersection: Please double checkif the crossection is closely located to a bifurcation.

These issues are not crashing the model generation, but it might be good to resolve them anyway.

Click for full traceback ``` 2024-10-15 15:17:18,903 - __main__ - dflowfm - INFO - Preparing 1D rivers. 2024-10-15 15:17:19,551 - __main__ - geodataframe - INFO - Reading 1D_branches vector data from C:\DATA\hydromt_delft3dfm\tests\data\local_data\1D_rivers.geojson 2024-10-15 15:17:19,573 - __main__ - geodataframe - DEBUG - Clip intersects [662568.208, 1523185.869, 666276.783, 1527293.217] (EPSG:32647) 2024-10-15 15:17:19,574 - __main__ - dataframe - INFO - Reading rivers_defaults csv data from C:\DATA\hydromt_delft3dfm\hydromt_delft3dfm\data\branches\rivers_defaults.csv 2024-10-15 15:17:19,580 - __main__ - branches - INFO - Set river locations filtered from branches as river . 2024-10-15 15:17:19,596 - __main__ - branches - INFO - Processing branches 2024-10-15 15:17:19,596 - __main__ - branches - DEBUG - Cleaning up branches 2024-10-15 15:17:19,601 - __main__ - branches - DEBUG - Exploding branches. 2024-10-15 15:17:19,603 - __main__ - branches - DEBUG - Removing 0 branches which have duplicated geometry. 2024-10-15 15:17:19,605 - __main__ - branches - DEBUG - Removing 0 branches that are shorter than 0.1 meter. 2024-10-15 15:17:19,609 - __main__ - branches - DEBUG - Renaming 0 id_col duplicates. Convention:BRANCH_1, BRANCH_1 --> BRANCH_1, BRANCH_1-2. 2024-10-15 15:17:19,612 - __main__ - branches - DEBUG - Reducing precision of the GeoDataFrame.Rounding precision (e-6) . 2024-10-15 15:17:19,614 - __main__ - branches - DEBUG - Performing snapping at all branch ends, including intersections(To avoid messy results, please use a lower snap_offset). 2024-10-15 15:17:19,615 - __main__ - branches - DEBUG - Splitting branches based on spacing 2024-10-15 15:17:19,618 - __main__ - branches - DEBUG - clipping branches into 2 segments 2024-10-15 15:17:19,619 - __main__ - branches - DEBUG - Generating branchnodes 2024-10-15 15:17:19,625 - __main__ - branches - INFO - Validating branches 2024-10-15 15:17:19,628 - __main__ - crosssections - INFO - Adding/Filling branches attributes values 2024-10-15 15:17:19,630 - __main__ - dflowfm - INFO - Preparing crossections from branch. 2024-10-15 15:17:19,642 - __main__ - geodataframe - INFO - Reading 1D_rivers_pointcrosssections vector data from C:\DATA\hydromt_delft3dfm\tests\data\local_data\1D_rivers_pointcrosssections.geojson 2024-10-15 15:17:19,656 - __main__ - geodataframe - DEBUG - Clip contains [662468.272, 1523085.917, 666376.762, 1527393.180] (EPSG:32647) 2024-10-15 15:17:19,657 - __main__ - dflowfm - INFO - Preparing 1D point crossections from 1D_rivers_pointcrosssections Crosssection with id: [1]are dropped: unable to find closest branch. No crossections are set up. 2024-10-15 15:17:19,672 - __main__ - model_api - WARNING - Replacing geom: crosssections 2024-10-15 15:17:19,673 - __main__ - geodataframe - INFO - Reading 1D_rivers_xyzcrosssections vector data from C:\DATA\hydromt_delft3dfm\tests\data\local_data\1D_rivers_xyzcrosssections.geojson 2024-10-15 15:17:19,689 - __main__ - geodataframe - DEBUG - Clip contains [661568.851, 1522186.356, 667276.568, 1528292.841] (EPSG:32647) 2024-10-15 15:17:19,691 - __main__ - dflowfm - INFO - Preparing 1D xyz crossections from 1D_rivers_xyzcrosssections Snapping to branches using intersection: Please double checkif the crossection is closely located to a bifurcation. 2024-10-15 15:17:19,722 - __main__ - model_api - WARNING - Replacing geom: crosssections 2024-10-15 15:17:19,724 - __main__ - dflowfm - DEBUG - Adding rivers and river_nodes vector to geoms. 2024-10-15 15:17:19,728 - __main__ - model_api - WARNING - Replacing geom: rivers 2024-10-15 15:17:19,730 - __main__ - dflowfm - DEBUG - Adding branches vector to geoms. 2024-10-15 15:17:19,731 - __main__ - dflowfm - DEBUG - Updating branches in network. ```