Deltares / hydromt_delft3dfm

Delft3D FM plugin for HydroMT
https://deltares.github.io/hydromt_delft3dfm/
GNU General Public License v3.0
9 stars 2 forks source link

Dsd 24 preparations #202

Closed shartgring closed 2 weeks ago

shartgring commented 2 weeks ago

Issue addressed

Fixes #201

Explanation

Explain how you addressed the bug/feature request, what choices you made and why.

Checklist

Additional Notes (optional)

For the DSD 2024. The demo will be on Monday the 11th in the afternoon

shartgring commented 2 weeks ago

Hi @shartgring Very nice introduction example! HydroMT core or more plugins could re-use it :)

A few notes left still:

  • usually the notebooks are stored on git without results so that when users download them they do not get your results in their notebooks. When building the docs, then the notebooks will be executed and the results will show. Leading to:
  • you may want to integrate this notebook in the docs. You have the list of examples: docs/getting_started/example_index.rst
  • and usually an extra page for example in how to build a model: docs/user_guide/dflowfm_build.rst

I did not run the notebook myself but I saw your results and there's not so muc code that can go wrong so I assume this is okay!

Good points, thanks! I will also walk with Vera through the code in a couple of minutes so that will also be a good test to see if no errors appear. I have included the new notebook in the docs and also fixed some types when doing it (as part of #198)

sonarcloud[bot] commented 2 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud