search

Deltares / imod_coupler

Application for coupling hydrological kernels.
https://deltares.github.io/iMOD-Documentation/coupler
MIT License
11 stars 0 forks source link

Use `h5netcdf` instead of `netCDF4` in exchange logging #321

Open Huite opened 3 months ago

Huite commented 3 months ago

I noticed this imports netCDF4:

https://github.com/Deltares/imod_coupler/blob/d53a5af0b6163fa88e040e15e5559c8844154e3b/imod_coupler/logging/exchange_collector.py#L5

I recommend using h5netcdf instead. We were having problems with netCDF4 before (and problems keep appearing now and then to be honest). I think h5netcdf is smaller too and results in a smaller pyinstaller bundle. It can be a bit faster too.

I thought I had made a change like this before, but I cannot find any commits...

Huite commented 3 months ago

It was this:

https://github.com/Deltares/imod_coupler/pull/171

Did this get reverted somehow?

Huite commented 3 months ago

This PR puts netCDF4 back: https://github.com/Deltares/imod_coupler/pull/286/files

Was that a conscious decision?