Deltares / rtc-tools

The Deltares toolbox for control and optimization of environmental systems.
GNU Lesser General Public License v3.0
0 stars 2 forks source link

draft: update writing variables to xml file #1631

Closed SGeeversAtVortech closed 1 month ago

SGeeversAtVortech commented 1 month ago

In GitLab by @SGeeversAtVortech on May 9, 2023, 15:32

When writing a variable to an xml file, it will loop over all aliases of this variable. The first alias that is in the rtcDataConfig file will be written to the xml file. The order of the aliases is random and therefore the actual variable that will be written is random. By ensuring that the original variable appears first in the list of aliases the behaviour is a bit less random and unexpected, especially when the variable itself is in the variable file.

SGeeversAtVortech commented 1 month ago

In GitLab by @SGeeversAtVortech on May 9, 2023, 15:32

requested review from @Ailbhemit

SGeeversAtVortech commented 1 month ago

In GitLab by @SGeeversAtVortech on May 9, 2023, 15:34

@Ailbhemit could you check if this branch fixes the issue for writing the variables to the xml file?