DemocracyClub / UK-Polling-Stations

:earth_africa: A website to help people find their UK polling station
https://wheredoivote.co.uk/
BSD 3-Clause "New" or "Revised" License
33 stars 30 forks source link

Show different registration info/polling station opening times for City of London local elections #8147

Closed chris48s closed 2 weeks ago

chris48s commented 3 weeks ago

Refs

This PR is part of the big pile of "deal with City of London edge cases" issues.

This is quite hard to do well on WDIV because it has the least nuanced view of "what election(s) are we telling the user about?"

In this PR I am looking at electoral registration details and polling station opening times but not ID requirements.

coveralls commented 2 weeks ago

Coverage Status

coverage: 70.906% (-0.006%) from 70.912% when pulling 02e2ccee4b7a0fbd3e111efd9d461ec604ddd15a on col20241106 into b9e5eb5fe2c43ff317b2ee47a349613394a274f2 on master.

chris48s commented 2 weeks ago

There is actually something I meant to mention when I originally wrote this PR that slipped my mind.

There is another place we show polling station opening times on WDIV. When polling day is today, we show this on the home page:

https://github.com/DemocracyClub/UK-Polling-Stations/blob/31f62e60421e7a0236ccdec1bef4d7979f2fd472/polling_stations/templates/home.html#L49-L57

This includes the opening hours, but because we haven't collected a postcode/address yet we can't tailor it based on the ballot(s). I wasn't really sure what to do with this.

GeoWill commented 2 weeks ago

I think either leave it as is or get rid. I err slightly to leaving it, but don't feel very strongly about it.

chris48s commented 2 weeks ago

Just having thought this through a bit more: The next scheduled City of London elections aren't on the same date as the main County/Mayor ones so we can special case this. If we aren't going to set 2025-03-20 as a "charismatic" date, this doesn't matter. If we are then we probably want to do something special. I'm going to punt this to an Asana card. https://app.asana.com/0/1204880927741389/1208755224696400/f