search

DemocracyClub / WhereDoIVote-Widget

:earth_africa: An embeddable widget that consumes the UK Polling Station API
MIT License
5 stars 4 forks source link

Use senedd.c not senedd (2) #707

Closed chris48s closed 5 months ago

chris48s commented 5 months ago

Fixed version of https://github.com/DemocracyClub/WhereDoIVote-Widget/pull/706 There's a bit more detail about exactly why I've made all the changes I have in the commit message for https://github.com/DemocracyClub/WhereDoIVote-Widget/pull/707/commits/7b8cb47a20ffc9c4d15a8160d31d8001c18aec0a

github-actions[bot] commented 5 months ago

This PR has been deployed.

VirginiaDooley commented 5 months ago

An afterthought: Should we add a pre_commit workflow that includes running tests?

chris48s commented 5 months ago

This project specifically uses husky to manage commit hooks, rather than pre-commit:

https://github.com/DemocracyClub/WhereDoIVote-Widget/blob/83ba4196e81adc713636bec00cb8743243d485bd/package.json#L83-L87

Personally I am against full test suite runs in commit hooks because

  1. Full test suite run is usually bit too slow to run on every commit
  2. It discourages TDD: Commit a failing test case - which is a helpful commit - becomes invalid

Either way, its scope creep for this PR. There are some more detailed conversations about sorting out dev experience on DC projects in our near future (but post GE polling day) :smile:.