Closed tal5 closed 1 year ago
Note: is there a reason for the id != -1 check? some internal Denizen thing?
I think that probably sources from the old version of the packet being an add/remove/modify multi-packet where it's -1
when it's not actually an add
Note: is there a reason for the id != -1 check? some internal Denizen thing?
I think that probably sources from the old version of the packet being an add/remove/modify multi-packet where it's-1
when it's not actually anadd
I see, removed it then - technically it'd be covered by getEntity
returning null
either way
Actionbar event packet handlers
baseComponent
toactionbarText
.Block light packet handlers
!BlockLight.lightsByChunk.isEmpty() -> call the method
instead of an (in this case redundant) early return.Fake players packet handlers
processFakePlayerSpawn
in favor of having the logic directly in the handler method.Collections#singletonList
withList#of
.Note: is there a reason for theremoved it, seems to be legacy handling from when that packet had several other functions.id != -1
check? some internal Denizen thing?Hide particles packet handlers
ParticleOptions particle
variable in favor of using the return value directly.