DennisRas / WeeklyKnowledge

Track your profession knowledge across your characters
https://www.curseforge.com/wow/addons/weeklyknowledge
5 stars 0 forks source link

Patron Orders #9

Open DennisRas opened 2 weeks ago

DennisRas commented 2 weeks ago

Look into whether Patron Orders have a soft/hard limit and whether we can track their weekly completion.

TJEEPOT commented 2 weeks ago

I left a comment on Curse but thought I'd leave it here too, just so you've got a better record of it.

I can pass on the hard limits I've been made of myself, but I haven't personally verified them: Alchemy: 8 Blacksmithing: 12 Engineering: 8 Inscription: 12 Jewelcrafting: 8 Leatherworking: 12 Tailoring: 12

There is no knowledge available from patron orders for Enchanting (and patron orders are not available for Cooking, Herbalism, Mining and Skinning, of course). Source: Pengu's The War Within Profession Sheet (Weekly KPs tab) from Penguinr2gt (YouTube).

DennisRas commented 2 weeks ago

@TJEEPOT Thank you :) I'll repost here what I wrote on CurseForge.

Hi there :-) Thanks for your kind words and feedback. I appreciate it. So we did talk about Patron Orders last night, but the current issue is to track what's completed and what's not. I need to see if getting those KP rewards from Patron Orders trigger a quest flag so we can track all the possible rewards. The numbers from the Sheet are great, but I need to have them confirmed, or somehow find the data ingame, so we can have the addon auto-update as time goes on. I'll follow up on this on the Github issue you've created. Thank you :-)

DennisRas commented 2 weeks ago

Should try and use this and complete some Patron Orders to see if any hidden quests are flagged when completing them: https://www.curseforge.com/wow/addons/questschanged

DennisRas commented 2 weeks ago

Completing a patron order does not flag any hidden quest. Tested with LW Patron Order and QuestsChanged installed.

TJEEPOT commented 2 weeks ago

Thanks for the update! Funny enough, I just grabbed QuestsChanged earlier to see if I could bring the hidden quest up myself, but it seems there's nothing when doing a Blacksmithing Patron Order, neither when accepting, completing, receiving the reward in the mail nor using the Glimmer of Blacksmithing Knowledge. I'll continue to check on my other crafters as suitable Patron Orders show up, though.

DennisRas commented 2 weeks ago

Thanks for the update! Funny enough, I just grabbed QuestsChanged earlier to see if I could bring the hidden quest up myself, but it seems there's nothing when doing a Blacksmithing Patron Order, neither when accepting, completing, receiving the reward in the mail nor using the Glimmer of Blacksmithing Knowledge. I'll continue to check on my other crafters as suitable Patron Orders show up, though.

We commented at the same time, with the same result :)

Another possible method could be to hardcode the numbers you posted above and then scan the Patron Orders available to see if the player still has any Patron Orders with Glimmering (KP) rewards and then count from there. I'm not sure how to handle Patron Orders expiring though. Do they re-appear within the same week? Do they show up as extra ("catch-ups") next week?

DennisRas commented 2 weeks ago

To clarify: When this expires, what happens to the reward? Is it lost for the week or does it come back in a new Patron Order or is it added to the pool of the next week? If a new Patron Order with a Glimmer reward reappears then we can safely check the count of Patron Orders with Glimmering rewards to track it all.

image

DennisRas commented 2 weeks ago

A couple of issues with this topic, as discussed on the WoWUIDev Discord: