DependencyTrack / dependency-track

Dependency-Track is an intelligent Component Analysis platform that allows organizations to identify and reduce risk in the software supply chain.
https://dependencytrack.org/
Apache License 2.0
2.72k stars 580 forks source link

Move GHSA notification logic outside recursion #4401

Closed antoinbo closed 1 day ago

antoinbo commented 6 days ago

Description

Fix GitHub Advisory Mirroring task triggering too many notifications.

Addressed Issue

4400

Additional Details

N/A

Checklist

codacy-production[bot] commented 6 days ago

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
:white_check_mark: +0.01% (target: -1.00%) :x: 0.00% (target: 70.00%)
Coverage variation details | | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (ea002e97163b32ad3f8cac6a9c45254819752c44) | 22581 | 17875 | 79.16% | | | Head commit (1fa388a4545a27213fab7962e0dee003ddab5f7a) | 22589 (+8) | 17883 (+8) | 79.17% (**+0.01%**) | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `
Diff coverage details | | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#4401) | 13 | 0 | **0.00%** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

nscuro commented 3 days ago

Thanks @antoinbo! Could you please sign-off your commit so that the DCO check succeeds? You can find instructions how to do that by clicking on the Details link next to the failing check.