New fix to from_bytes_noalloc does not work with Cascade.

Derecho-Project / derecho

The main code repository for the Derecho project.

BSD 3-Clause "New" or "Revised" License

187 stars 47 forks source link

New fix to from_bytes_noalloc does not work with Cascade. #203

Closed songweijia closed 3 years ago

songweijia commented 3 years ago

Here is the link to the description: https://github.com/Derecho-Project/derecho/commit/cc5f3d6d9ab2e2779ab59de5741936ccb19207f8#commitcomment-52894099

I suspect this is a minor issue where the serialization macro generated the code for from_bytes_noalloc with the old assumption. If it is, we need to check throughout SerializationSupport.hpp to make sure we didn't miss anything.