DerekTurtleRoe
commented
8 months ago @rapha-sampaio Hello! Thanks for the pull request! 😄
My only issue with adding an emoji specifically for developers and debugging tools is that a majority of the emulators on the list would need that added, and I think when switching to the table format that might be better if I add that later (if at all).
Emulators within commercial hardware projects like the Xbox compatibility modes, backwards compatibility with systems like PlayStation and Nintendo systems, and Game Boy/DS are probably best left off the list. There are way too many systems with backwards compatibility and most people if they own the system already know about those modes.
Officially provided emulators for software development like Nintendo's "Ensata" emulator probably shouldn't be listed considering there are no ways to legally acquire them anymore. The official Game.Com emulator is another emulator I won't put on the list since it was only included with the official SDK as far as I know.
I'm fine with adding NO$GBA in general, but the "The 3DS functionality is still being implemented, not ready for use" part should probably be omitted until it is released (if Martin even plans on adding that).
One last thing, why was the license moved down? Not sure if that was intentional or not.
So before merging, I would like for you to:
- Remove the development/debugging emoji
- Remove the compatibility modes since they are outside the scope of this list
- Remove official emulators
- Remove the note attached to NO$GBA
- Move the license info back to where it was
The additional emulators and everything else looks good though. Thanks for the PR. 😄
I will review the PR again after the changes are made. 👍
EDIT: Optionally I can just take the additions I want and merge them manually if you'd prefer.
.