search

DescartesResearch / TeaStore

A micro-service reference test application for model extraction, cloud management, energy efficiency, power prediction, single- and multi-tier auto-scaling
https://se.informatik.uni-wuerzburg.de
Apache License 2.0
118 stars 137 forks source link

Latest WebUI image doesn't match the code on master branch #178

Closed msnteixeira closed 3 years ago

msnteixeira commented 3 years ago

When building the descartesresearch/teastore-webui:latest image from DockerHub, the deployment works fine using HTTP.

However when building from the code, because the Cookie.setSecure flag is set to True, for example here, the deployment using HTTP no longer works when doing actions that require cookies such like adding teas to the cart.

From our point of view, the code needs to match the latest WebUI image.

SimonEismann commented 3 years ago

In terms of master branch vs image content, our philosophy currently is that we only build the images for current releases, so the current image matches to the content of the commit tagged for version 1.3.8 (see https://github.com/DescartesResearch/TeaStore/tags). So if you are looking to customize something and compare it to the 1.3.8 image, you could checkout the corresponding commit and adapt it. Is there any specific need from our end to have the current state of the master branch match the image?

In regard to the secure cookies breaking the WebUI, I'll quickly test if I can reproduce this issue and then switch back to unsecured cookies. Thanks for letting us know about this issue, otherwise this breaking bug would have probably made its way into v1.3.9 :)

SimonEismann commented 3 years ago

I was able to replicate this issue and therefore removed the secure cookies again :-)

Thanks for reaching out about this, feel free to reopen this issue in case there are any further issues