Fix VCPKG builds in GitHub CI - Githubissues

DescentDevelopers / Descent3

Descent 3 by Outrage Entertainment

GNU General Public License v3.0

2.88k stars 251 forks source link

Fix VCPKG builds in GitHub CI #512

Closed tophyr closed 3 months ago

tophyr commented 3 months ago

Pull Request Type

[x] GitHub Workflow changes
[ ] Documentation or Wiki changes
[x] Build and Dependency changes
[ ] Runtime changes
- [ ] Render changes
- [ ] Audio changes
- [ ] Input changes
- [ ] Network changes
- [ ] Other changes

Description

https://github.com/DescentDevelopers/Descent3/commit/e5dcce3c9fd3ccb36b1b72e3cd919d42c058c2e4 added VCPKG support and described, correctly, how to use it in the README but did not add the correct dependencies to the CI definitions.

Checklist

[x] I have tested my changes locally and verified that they work as intended.
[x] I have documented any new or modified functionality.
[x] I have reviewed the changes to ensure they do not introduce any unnecessary complexity or duplicate code.
[x] I understand that by submitting this pull request, I am agreeing to license my contributions under the project's license.

Lgt2x commented 3 months ago

For context, the SDL2 library we now build can change depending on which system headers are installed at compile-time.

Props to OpenTTD contributors who figured this out before!