Fix audio distortions on MVE playback with pipewire backend - Githubissues

DescentDevelopers / Descent3

Descent 3 by Outrage Entertainment

GNU General Public License v3.0

2.88k stars 251 forks source link

Fix audio distortions on MVE playback with pipewire backend #552

Closed winterheart closed 2 months ago

winterheart commented 2 months ago

Don't define fixed buffer length for audio device, SDL2 calculates desired length itself. Minor cleanups and fixes to virtual class and constructor.

Pull Request Type

[ ] GitHub Workflow changes
[ ] Documentation or Wiki changes
[ ] Build and Dependency changes
[x] Runtime changes
- [ ] Render changes
- [x] Audio changes
- [ ] Input changes
- [ ] Network changes
- [ ] Other changes

Description

Related Issues

Fixes #551.

Screenshots (if applicable)

Checklist

[x] I have tested my changes locally and verified that they work as intended.
[x] I have documented any new or modified functionality.
[x] I have reviewed the changes to ensure they do not introduce any unnecessary complexity or duplicate code.
[x] I understand that by submitting this pull request, I am agreeing to license my contributions under the project's license.

Additional Comments