DescentDevelopers / Descent3

Descent 3 by Outrage Entertainment
GNU General Public License v3.0
2.88k stars 251 forks source link

Fix dedicated runtime error #578

Closed winterheart closed 2 months ago

winterheart commented 2 months ago

Pull Request Type

Description

netgame_info is limited by PAGENAME_LEN (35) and this cause SIG_ABORT if user pass very long filename to -dedicated config option, as discovered in #571. Additional check for filename existence. Minor enhancements to related code.

Related Issues

Fixes #571

Screenshots (if applicable)

Checklist

Additional Comments

jengelh commented 2 months ago

There's a more comprehensive resolution in #579 for part of the issues. SIGABRT is not guaranteed, in my case it just wrote past the buffer silently, because, AIUI, not even ASAN adds guard zones inside structs so they stay layout-compatible to non-ASAN-enabled code.

winterheart commented 2 months ago

Superseded by #579