[Build Failure]: “plog third-party directory could not be found.”

Jayman2000 commented 2 months ago

Build Version

v1.6 705c67a1be01741a1fa81c9d84e975daccdc3143

Operating System Environment

[ ] Microsoft Windows (32-bit)
[X] Microsoft Windows (64-bit)
[ ] Mac OS X
[X] Linux (specify distribution and version below)

CPU Environment

[ ] x86 (32-bit Intel/AMD)
[X] x86_64 (64-bit Intel/AMD)
[ ] ARM (32-bit)
[ ] ARM64 (64-bit; sometimes called AArch64)
[ ] Other (RISC V, PPC...)

Description

When I follow Descent 3’s build instructions, I get this error:

CMake Error at third_party/CMakeLists.txt:10 (message):
  plog third-party directory could not be found.  Please run 'submodule
  update --init --recursive' in the source directory.

I was able to reproduce that error by building Descent 3 on:

Fedora 40 x86_64 with vcpkg
Fedora 40 x86_64 without vcpkg
Ubuntu 24.04.1 x86_64 with vcpkg
Ubuntu 24.04.1 x86_64 without vcpkg
Windows 10 x86_64

Interestingly enough, the build instructions for macOS say to run git clone --recurse-submodules https://github.com/DescentDevelopers/Descent3. The build instructions for the other platforms don’t tell you to use --recurse-submodules.

Regression Status

The oldest commit that has this problem is c6ab519652fc87c053209fc3d677bea0b84f937b. The newest commit that doesn’t have this problem is 76ddbefb094afb7b6ab938819d20d0a6ee966dea.

Steps to Reproduce

Try building the game on either Linux or Windows by following the build instructions.

sirken commented 2 months ago

After plog was recently introduced, I had the same issue when pulling the latest commit and compiling on Linux. This fixed it for me and allowed the build process to continue

git submodule update --init --recursive

Lgt2x commented 2 months ago

Please run 'submodule update --init --recursive' in the source directory.

I'm just noticing now that git is missing from the error message

DescentDevelopers / Descent3