cfile: Replace cf_LibraryFindFirst() with cf_DoForeachFileInLibrary()

[winterheart]

Pull Request Type

• [ ] GitHub Workflow changes
• [ ] Documentation or Wiki changes
• [x] Build and Dependency changes
• [ ] Runtime changes
  • [ ] Render changes
  • [ ] Audio changes
  • [ ] Input changes
  • [ ] Network changes
  • [ ] Other changes

Description

• Remove unused cf_ChangeFileAttributes()
• Replace bulky cf_LibraryFindFirst() / cf_LibraryFindNext with cf_DoForeachFileInLibrary(), which simplifies code.

Related Issues

Fixes #605

Screenshots (if applicable)

Checklist

• [x] I have tested my changes locally and verified that they work as intended.
• [x] I have documented any new or modified functionality.
• [x] I have reviewed the changes to ensure they do not introduce any unnecessary complexity or duplicate code.
• [x] I understand that by submitting this pull request, I am agreeing to license my contributions under the project's license.

Additional Comments

[Jayman2000]

I just tested this PR on NixOS 24.05 (x86_64) and Windows 10 (x86_64). It seems to work fine, but I wasn’t really able to test it out thoroughly on Windows due to #605.

[pzychotic]

Tested with success on Windows 11 and makes my #609 redundant.