DesiQuintans / librarian

Install, Update, Load Packages from CRAN, Bioconductor, and GitHub in One Step.
GNU General Public License v3.0
54 stars 1 forks source link

Packages with different GitHub package are not detected as installed #32

Open yamanq opened 1 year ago

yamanq commented 1 year ago

System info

Librarian version : 1.8.1
R Version         : 4.2.0

What problem do you get?

When using stock on a package that has a different name from its GitHub repository, the installation is successful but check_installed does not detect it correctly

How do you reproduce the problem?

Stock a package with a different repository name from the package name This repository contains SeuratDisk:

librarian::stock(mojaveazure/seurat-disk)

How to fix the issue

This can probably be directly fixed by reading the output of remotes::install_github, since it returns the package names. It might cause some control flow issues in other functions since seurat-disk is detected as not installed.

Additional Information

Relevant issue: https://github.com/r-lib/remotes/issues/55