search

Deskins-group / Other-Files

Misc files and utilities we've developed.
2 stars 2 forks source link

Wrong format of mixed use of Tabs and Spaces #3

Open Satinelamp opened 2 years ago

Satinelamp commented 2 years ago

The BDM-polaron-vasp.py uses Tabs and spaces together, which could cause issues,

Snipaste_2021-12-25_02-42-35 I am using python3, so I transform this script with official 2to3.py, but when testing the script, there are still some errors, I am not sure if this error is related to the mixed use of tabs and spaces, but I still suggest a modification and upgrade to python3 might be better. Snipaste_2021-12-25_02-47-15

aarondesk commented 2 years ago

Hi Jack, I will look into this. The script has been working for me, so I'm not sure what the problem is. Best, Aaron

From: Jack1994 @.> Sent: Friday, December 24, 2021 1:50 PM To: Deskins-group/Other-Files @.> Cc: Subscribed @.***> Subject: [EXT] [Deskins-group/Other-Files] Wrong format of mixed use of Tabs and Spaces (Issue #3)

The BDM-polaron-vasp.py uses Tabs and spaces together, which could cause issues,

[Snipaste_2021-12-25_02-42-35]https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F62006565%2F147369138-0b1a9c6c-dc7d-401c-926b-eb66188f6578.png&data=04%7C01%7Cnadeskins%40wpi.edu%7C2b421beed4a448b2a69908d9c70e419e%7C589c76f5ca1541f9884b55ec15a0672a%7C0%7C0%7C637759686315258590%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=qz8Cd1WgJRPknVsJRhspd%2F5YkOFu5HWayXcEkNjGB3g%3D&reserved=0 I am using python3, so I transform this script with official 2to3.py, but when testing the script, there are still some errors, I am not sure if this error is related to the mixed use of tabs and spaces, but I still suggest a modification and upgrade to python3 might be better. [Snipaste_2021-12-25_02-47-15]https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F62006565%2F147369248-dad1c381-be16-4fc9-af16-5b5f3ca65243.png&data=04%7C01%7Cnadeskins%40wpi.edu%7C2b421beed4a448b2a69908d9c70e419e%7C589c76f5ca1541f9884b55ec15a0672a%7C0%7C0%7C637759686315258590%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=NVqD2kCTW4cpKjY5bO6vCWg2cpA0ITlepyJnoI9qMfY%3D&reserved=0

— Reply to this email directly, view it on GitHubhttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FDeskins-group%2FOther-Files%2Fissues%2F3&data=04%7C01%7Cnadeskins%40wpi.edu%7C2b421beed4a448b2a69908d9c70e419e%7C589c76f5ca1541f9884b55ec15a0672a%7C0%7C0%7C637759686315258590%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=WRMvV3hj0RZwzihBaKu7LpoegawGjDHofoULyhh5dhQ%3D&reserved=0, or unsubscribehttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAD3DMYXGXUAEGVYZFEW3APTUSS6HLANCNFSM5KW6WCEA&data=04%7C01%7Cnadeskins%40wpi.edu%7C2b421beed4a448b2a69908d9c70e419e%7C589c76f5ca1541f9884b55ec15a0672a%7C0%7C0%7C637759686315258590%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=DPant%2Bc6%2BhzQAPr4eR5gLIvIyMlb3wU%2F%2FFloIkqcfKM%3D&reserved=0. Triage notifications on the go with GitHub Mobile for iOShttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7Cnadeskins%40wpi.edu%7C2b421beed4a448b2a69908d9c70e419e%7C589c76f5ca1541f9884b55ec15a0672a%7C0%7C0%7C637759686315258590%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=SKSksFJTYKMLoyzxX%2B9q%2FmAWdjTe73RVeKsfKvfrBJA%3D&reserved=0 or Androidhttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7Cnadeskins%40wpi.edu%7C2b421beed4a448b2a69908d9c70e419e%7C589c76f5ca1541f9884b55ec15a0672a%7C0%7C0%7C637759686315258590%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=7IrD%2BJbQ0%2BI7OkLhF5UpufUwTD%2BBd0C%2FVwArQ794c3Y%3D&reserved=0. You are receiving this because you are subscribed to this thread.Message ID: @.***>

aarondesk commented 2 years ago

I uploaded a version that works with python 3 (test on mac with python 3). Note that the script is designed to work in unix/linux environment. I don't know how it will do in windows. The program takes input from sys.argv - not sure how this works in windows environment and if it will read these input values correctly. If you have problems with input, you can change the script manually for the correct input values if sys.arg isn't working properly.