DeuxVis / Lora-TTNMapper-T-Beam

TTNMapper on the TTGO T-Beam
GNU General Public License v3.0
109 stars 47 forks source link

Confusing definition of GPS_RX and GPS_TX #23

Open jayAitch256 opened 3 years ago

jayAitch256 commented 3 years ago

I'm trying to adapt this sketch for a custom ESP32 based board with an external GPS and a different pinmap. After a while I realized that GPS_RX and GPS_TX (gps.h) are defined in a pretty unusual way here.

The pin GPS_RX means the TX pin of the ESP here (wired to RX of the GPS). GPS_TX is the RX pin of the ESP (wired to TX of the GPS).

I understand that this won't really matter if you just use the T-Beam, but for others who are planning to reuse the code for other boards, this notice might be helpful since it is not the "normal" way most people would handle the terms RX and TX.