DevAhamed / MultiViewAdapter

Easily create complex recyclerview adapters in android
https://devahamed.github.io/MultiViewAdapter
Apache License 2.0
818 stars 148 forks source link

Add the HeaderSections rather than the sections themselves. #106

Closed ElectricMagic closed 4 years ago

ElectricMagic commented 4 years ago

The xxxSection is being added to the adapter, rather than the enclosing xxxHeaderSection. Error is reported by addSection throwing IllegalStateException("Section is already has a parent!")

codecov-io commented 4 years ago

Codecov Report

Merging #106 into 2.x will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              2.x     #106   +/-   ##
=======================================
  Coverage   75.78%   75.78%           
=======================================
  Files          20       20           
  Lines        1177     1177           
  Branches      174      174           
=======================================
  Hits          892      892           
  Misses        181      181           
  Partials      104      104

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 76c436f...4b614fc. Read the comment docs.

DevAhamed commented 4 years ago

Thanks for the contribution!

ElectricMagic commented 4 years ago

On 12 Nov 2019, at 03:20, Riyaz Ahamed notifications@github.com wrote:

Thanks for the contribution!

Thanks for the library! Do you know when 3.0.0 will be in JCenter?

A++


Andrew Green skype:electricmagic ag@em.net Electric Magic Co. +1 (831) 621 1822

DevAhamed commented 4 years ago

Please take a look here - https://github.com/DevAhamed/MultiViewAdapter/tree/3.x

ElectricMagic commented 4 years ago

On 27 Nov 2019, at 20:27, Riyaz Ahamed notifications@github.com wrote:

Please take a look here - https://github.com/DevAhamed/MultiViewAdapter/tree/3.x

I completely missed your very prompt reply. That's great news, thank you very much.

A++


Andrew Green skype:electricmagic ag@em.net Electric Magic Co. +1 (831) 621 1822