Styled Markup Feedback!

[rijkvanzanten]

• [x] reset.css is empty. I'd just drop it from the repo in that case
• [x] I'd wrap font names containing spaces in ". Some tooling and browser can choke on the spaces
• [x] A hr tag is a semantic thematic change in content. Feels like you're using it here for stylistic purposes exclusively. Use a border in CSS instead.

• [ ] From MDN:

  The <article> HTML element represents a self-contained composition in a document, page, application, or site, which is intended to be independently distributable or reusable

  You're wrapping the article's title and author in a separate article, indicating that it's disconnected from the article itself. Those two shouldn't be independently distributable so shouldn't be wrapped in a separate article

• [x] This looks like a block quote and cite to me!
• [x] Opening span, closing cite; seems like some things aren't going to plan here
• [x] We're you inspired by the class website of last year? Feels very familiar 😄
• [x] If only there was an element for inline quotes 👀

[Devanshkhajanchi]

Hey Rjik, thanks for these comments! Putting down some of my responses to your comments below:

1. Haha I had the same conversation with Michael about my layout looking like last year's course site! Looks like a happy coincidence! I took inspiration from Massimo Vignelli's work – the use of Black, White and Red, and the fact that he loved Garamond! Hope this isn't a problem? If you feel so, I could change the layout, might be able to do it in a couple of days.
2. Regarding the foreword, I discussed the same with Michael last week, he advised me to use 'aside'. I debated wether I should use aside or a blockquote and eventually used aside. Do you feel a blockquote would be more correct semantically?
3. I'm sorry i'm not quite sure I understood your comment on
   . I've divided my layout into 3 articles – The Foreword, the actual article and my response, with the titles for all 3 being nested under their respective

   tags. Could you please elaborate?

[rijkvanzanten]

1. haha no problem! Funny coincidence
2. I think it's both! It's an aside with a blockquote in it 🙂
3. Each <article> has to be "self-contained". For example you should be able to remove an article and put it on a different page and have it make sense from a content perspective. If I were to cut and paste your first article tag from the HTML, the text would no longer make sense