search

Developer-Students-Club-MAIT / cool_code_snippets

This is a repository for adding not so popular/known but very useful and cool code snippets in any language or framework that the community might benefit from
MIT License
12 stars 16 forks source link

Longest Common Subsequence #30

Closed Bhaswati-Saha closed 4 years ago

Bhaswati-Saha commented 4 years ago

Longest Common Subsequence

Fixes: #3

Made modifications. Given proper class name and comments. Removed extra lines and made a simple table format for contribution. Also I have edited the title of the pull request.

Type of change [ Y] New feature (non-breaking change which adds functionality) Checklist: [ Y] My code follows the style guidelines of this project [ Y] I have performed a self-review of my own code [ Y] I have commented my code, particularly in hard-to-understand areas [ Y] I have made corresponding changes to the documentation [ Y] My changes generates no new warnings [ Y] I have added tests that prove my fix is effective or that my feature works [ Y] New and existing unit tests pass locally with my changes [ Y] Any dependent changes have been merged and published in downstream modules

Bhaswati-Saha commented 4 years ago

Longest Common Subsequence

Related: Issue #3

Made modifications. Given proper class name and comments. Removed extra lines and made a simple table format for contribution. Also I have edited the title of the pull request.

Type of change [ Y] New feature (non-breaking change which adds functionality) Checklist: [ Y] My code follows the style guidelines of this project [ Y] I have performed a self-review of my own code [ Y] I have commented my code, particularly in hard-to-understand areas [ Y] I have made corresponding changes to the documentation [ Y] My changes generates no new warnings [ Y] I have added tests that prove my fix is effective or that my feature works [ Y] New and existing unit tests pass locally with my changes [ Y] Any dependent changes have been merged and published in downstream modules

kaustubhgupta commented 4 years ago

Edit the PR template instead of posting it as a comment

Bhaswati-Saha commented 4 years ago

Edit the PR template instead of posting it as a comment

Means in the previous PR message I will just have to specify the changes I have made in the "Type of change" field and I don't have to comment any further?

Bhaswati-Saha commented 4 years ago

Edit the PR template instead of posting it as a comment

okay I have edited the PR template. Please check it if there is any more errors.