DeviceFarmer / stf

Control and manage Android devices from your browser.
https://devicefarmer.github.io
Other
3.52k stars 497 forks source link

Wrong minicap invocation inside the 'util' unit #701

Open ghost opened 1 year ago

ghost commented 1 year ago

https://github.com/DeviceFarmer/stf/blob/3d3af0e9acf91d8beca500390e88d4ebd518f4ef/lib/units/device/plugins/util/display.js#L31C23-L31C23

This doesn't happen in most cases since this is only triggered if a certain exception happen in the 'readInfo' function, although when triggered infoFromMinicap calls minicap.run with a single command parameter, although the run method expects 2 arguments, more specifically, the minicap mode, either 'minicap-apk' or 'minicap-bin'.

I'm not sure how to reproduce this, but a simple look at the code will be enough.