search

Devographics / Monorepo

Monorepo containing the State of JS apps
surveyform-sigma.vercel.app
Other
135 stars 52 forks source link

@font-face issue #134

Open SachaG opened 2 years ago

SachaG commented 2 years ago

For some reason @font-face declarations are getting repeated way to many times:

Screen Shot 2022-10-06 at 10 25 17
eric-burel commented 2 years ago

This is probably not a technical issue but something with how we load google fonts (you'll have the same on IBM plex). Each have a different unicode range, that's what we need to understand. Then there probably are some options to load only relevant one.

Also, it seems that these days we don't benefit that much from loading from google, since caching shared assets leads to privacy issues? We could host Roboto and IBM Plex in app.

Need more reading.

SachaG commented 2 years ago

Oh really? To me it looked like the same code was being repeated but maybe I didn't pay close enough attention. It's also arguable whether we even need custom fonts for a survey app… Let alone two of them, and one (Roboto) we don't even use!

System fonts would probably be the better choice here: https://systemfontstack.com/

eric-burel commented 2 years ago

I've removed Roboto and only kept IBM Plex since we use it.

According to SO https://stackoverflow.com/questions/60998287/too-many-fonts-loading-from-google-fonts the various encodings are needed to get correct support of other alphabets.

We could maybe load the right encoding depending on i18n but that sounds too advanced for now and risky (I prefer a few extra bytes than breaking Chinese translation, all the more that we don't test that often and it's hard to automate testing)