search

DiamondLightSource / httomolibgpu

A library of GPU-enabled data processing and reconstruction methods for tomography
https://diamondlightsource.github.io/httomolibgpu/
Other
4 stars 4 forks source link

Provide other padding options in `paganin_filter_tomopy` #155

Open yousefmoazzam opened 1 week ago

yousefmoazzam commented 1 week ago

Just to improve the visibility of this TODO I saw in a code comment so it's less likely to get missed: https://github.com/DiamondLightSource/httomolibgpu/blob/ce1c15f0a9e09a6fd3070375f473ece421b06685/httomolibgpu/prep/phase.py#L303-L305

dkazanc commented 2 days ago

I guess there are 2 things, padding in a sense of extending the area and also filling the padding area with some values. This comment refers to the former but it could be the latter that it is more important. Apparently, padding with zero values can be not the best choice. Coming back to this issue, I'm not sure what exactly we gain if we do the padding area smaller for instance. It requires a bit of benchmarking first, but I think initially this was a comment to deal with the fact that in TomoPy they do not scale to the power of 2. Which is good when the memory is in question.