codecov[bot]
commented
1 week ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 85.00%. Comparing base (
9aa3698) to head (66120f3). Report is 1 commits behind head on main.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #661 +/- ## ======================================= Coverage 85.00% 85.00% ======================================= Files 98 98 Lines 6548 6548 ======================================= Hits 5566 5566 Misses 982 982 ``` | [Components](https://app.codecov.io/gh/DiamondLightSource/mx-bluesky/pull/661/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DiamondLightSource) | Coverage Δ | | |---|---|---| | [i24 SSX](https://app.codecov.io/gh/DiamondLightSource/mx-bluesky/pull/661/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DiamondLightSource) | `69.59% <ø> (ø)` | | | [hyperion](https://app.codecov.io/gh/DiamondLightSource/mx-bluesky/pull/661/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DiamondLightSource) | `96.79% <ø> (ø)` | | | [other](https://app.codecov.io/gh/DiamondLightSource/mx-bluesky/pull/661/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DiamondLightSource) | `94.97% <ø> (ø)` | |🚨 Try these New Features:
- Flaky Tests Detection - Detect and resolve failed and flaky tests
Similar to https://github.com/DiamondLightSource/dodal/pull/903.
On removing setting the timeouts the tests still passed at the same speed so turns out we're not using them at all. However, it did highlight that
test_detect_grid_and_do_gridscanwas a bit flaky. This was because we were using the "real" backlight positioner, which takes some time to move in/out. Previous tests were doing the move and not waiting on it, then this test would fail on the check. Fixed by using the fake one that moves instantly.To test: