#1032: Migrates of PFADD, PFCOUNT, PFMERGE to Multi-threaded architecture. - Githubissues

DiceDB / dice

DiceDB is a redis-compliant, reactive, scalable, highly-available, unified cache optimized for modern hardware.

https://dicedb.io/

Other

6.88k stars 1.09k forks source link

#1032: Migrates of PFADD, PFCOUNT, PFMERGE to Multi-threaded architecture. #1097

Closed surya0180 closed 1 month ago

surya0180 commented 1 month ago

This PR closes #1032.

Here are things that are done

[x] Migrated the evalXXX function with the latest definition
[x] Update or add unit tests for the new implementation.
[x] All unit tests pass successfully.
[x] Ensure all integration tests pass successfully.
[x] Ensure integration tests are added for the migrated command on multi-threaded resp server.

surya0180 commented 1 month ago

Ok, Integration tests are not updated. I will update them and add another commit

surya0180 commented 1 month ago

@AshwinKul28 @apoorvyadav1111 @lucifercr07 @JyotinderSingh

The checks have passed and this PR is ready to be reviewed.

surya0180 commented 1 month ago

@benjaminmishra I have made the changes as requested. Please review them and let me know if everything looks fine

soumya-codes commented 1 month ago

@surya0180 lets ensure that the corresponding integration tests are migrated as well. cc @AshwinKul28

AshwinKul28 commented 1 month ago

@surya0180 Please add respective RESP integration tests. Thanks

surya0180 commented 1 month ago

@surya0180 lets ensure that the corresponding integration tests are migrated as well. cc @AshwinKul28

Is this what @soumya-codes is referring to?